[File-cvs] CVS commit: file/src

Christos Zoulas christos at zoulas.com
Sun May 5 19:22:36 UTC 2019

Module Name:	file
Committed By:	christos
Date:		Sun May  5 19:22:36 UTC 2019

Modified Files:
	file/src: compress.c

Log Message:
>From Denys Vlasenko:

This makes more clear what fds are closed when, when you read
caller function code.

This is a preparation to not clobber fdp[] in the child, so that
we can switch to using vfork() in a later patch.

Add ///BUG comments:
(*) we wait() in writechild, thus, if write() in writing child blocks
waiting for decompressor to consume data, and decompressor blocks waiting
ofr _us_ to read its data, we would deadlock.
(*) we can't know that the child we spawned is the only running child
of the process. We should use waitpid() to wait specifically for
the child we need.

Will fix in patch 4.

To generate a diff of this commit:
cvs rdiff -r1.117 -r1.118 file/src/compress.c

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.

More information about the File-cvs mailing list