[File] Possible ABI break when updating file from 5.33 to 5.35

Christos Zoulas christos at zoulas.com
Wed Jan 30 02:19:35 UTC 2019


It was a mistake that they were. In the future I will probably use a linker script to make sure that the only things exposed are part of the ABI/API.

christos

> On Jan 29, 2019, at 12:41 PM, <emersonbernier at tutanota.com> <emersonbernier at tutanota.com> wrote:
> 
> Jan 26, 2019, 8:04 PM by christos at zoulas.com <mailto:christos at zoulas.com>:
> 
>> Hi,
>> 
>> Although those changes look scary, there is nothing to be concerned about:
>> 1. the functions missing are not part of the ABI (and programs should not be using them)
>> 2. the magic_set structure is not exposed in the ABI.
>> 
>> The only thing you need to make sure is that the magic database and the magic library are
>> consistent...
>> 
>> christos
>> 
> One question though. If those functions/variables aren't supposed to be used by programs then why they're exported? Not exporting them will make sure there aren't used even by mistake.
> 
> Emerson



More information about the File mailing list