[File] One more set of observations from static analysis

[Christos Zoulas]

Unfortunately magic.h is handled in Makefile.am in src:

CLEANFILES = magic.h
EXTRA_DIST = magic.h.in
HDR= $(top_srcdir)/src/magic.h.in
BUILT_SOURCES = magic.h

magic.h:        ${HDR}
        sed -e "s/X.YY/$$(echo @VERSION@ | tr -d .)/" < ${HDR} > $@

Now we could write some m4 that does this during the configure phase
so we can add it in AC_CONFIG_FILES()...
I am not sure though why magic.h did not get rebuilt in your case or if
the problem is that the static analysis tool did not have -I.

christos
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <https://mailman.astron.com/pipermail/file/attachments/20200608/81268b5a/attachment.asc>