[File] [PATCH] improve JAR detection & fix some ext/mime lines

Christos Zoulas christos at zoulas.com
Wed Jan 18 16:29:24 UTC 2023

On 2023-01-16 3:46 pm, FC Stegerman wrote:
> Hi!
> I realised that when the APK detection fails to find anything specific
> to Android after it finds a JAR-specific META-INF/MANIFEST.MF, it
> knows it has detected a JAR file (which may or may not be an APK).
> With apk3.patch, the 224 APKs in F-Droid that could not be detected as
> APKs are at least detected as JARs, not just ZIPs.
> I also realised I had put the !:mime/!:ext lines in the wrong place
> previously, and missed one in my JavaScript patch; sorry about that.
> I've attached two patches: apk3.patch to detect files with
> META-INF/MANIFEST.MF that cannot be detected as APKs as JARs and fix
> the !:mime/!:ext lines; and html.patch to add the missing !:mime line
> for HTML files.
> - FC

Committed, thanks!


More information about the File mailing list