<html><head><meta http-equiv="Content-Type" content="text/html; charset=utf-8"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;" class="">You got it!<div class=""><br class=""></div><div class="">christos<br class=""><div><br class=""><blockquote type="cite" class=""><div class="">On Dec 9, 2021, at 11:05 AM, Vincent Mihalkovic <<a href="mailto:vmihalko@redhat.com" class="">vmihalko@redhat.com</a>> wrote:</div><br class="Apple-interchange-newline"><div class=""><p class=""><defanged_div dir="ltr" class=""></defanged_div></p><p class=""><defanged_div class="">Hi, </defanged_div></p><defanged_div class=""><p class=""><defanged_div class=""><br class=""></defanged_div></p><defanged_div class=""><p class=""><defanged_div class="">from <a href="https://bugzilla.redhat.com/show_bug.cgi?id=2020715" target="_blank" class="">https://bugzilla.redhat.com/show_bug.cgi?id=2020715</a>:</defanged_div></p><defanged_div class=""><p class=""><defanged_div class=""><br class=""></defanged_div></p><defanged_div class="">"Description of problem:<br class=""><br class="">The command "file" applied to a JSON file now outputs "JSON data", without<br class="">including the string "text" in the output. Earlier versions behaved differently -<p class=""><defanged_div class="">on CentOS 6 file returned just "ASCII text" for JSON file,and this is also </defanged_div></p><defanged_div class=""><p class=""><defanged_div class="">contrary to the documentation of file (man file), which states:</defanged_div></p><p class=""><defanged_div class=""><br class=""> The type printed will usually contain one of the words text (the file<br class=""> contains only printing characters and a few common control characters and<br class=""> is probably safe to read on an ASCII terminal), executable (the file con‐<br class=""> tains the result of compiling a program in a form understandable to some<br class=""> UNIX kernel or another), or data meaning anything else (data is usually<br class=""> “binary” or non-printable). Exceptions are well-known file formats (core<br class=""> files, tar archives) that are known to contain binary data. When modify‐<br class=""> ing magic files or the program itself, make sure to preserve these<br class=""> keywords. Users depend on knowing that all the readable files in a di‐<br class=""> rectory have the word “text” printed. Don't do as Berkeley did and<br class=""> change “shell commands text” to “shell script”.<br class=""><br class="">Apparently file has now done as Berkeley did..."<br class=""></defanged_div></p><p class=""><defanged_div class=""><br class=""></defanged_div></p><defanged_div class=""><div class=""><br class="webkit-block-placeholder"></div><defanged_div class=""><div class=""><br class="webkit-block-placeholder"></div><defanged_div class=""><p class=""><defanged_div class="">What do you think about changing the "JSON data" to "JSON text data" ?</defanged_div></p><defanged_div class=""><p class=""><defanged_div class=""><a href="https://github.com/file/file/blob/b56b58d499dbe58f2bed28e6b3c297fe7add992e/src/is_json.c#L417" class="">https://github.com/file/file/blob/b56b58d499dbe58f2bed28e6b3c297fe7add992e/src/is_json.c#L417</a></defanged_div></p><defanged_div class=""><p class=""><defanged_div class=""><br class=""></defanged_div></p><defanged_div class=""><p class=""><defanged_div class="">vincent mihalkovic</defanged_div></p><defanged_div class=""><p class=""><defanged_div class=""><br class=""></defanged_div></p><defanged_div class=""><div class=""><br class="webkit-block-placeholder"></div><defanged_div class="">
<span id="cid:f_kwz5hiw50"><file-5.41-JSON-text.patch></span>-- <br class="">File mailing list<br class=""><a href="mailto:File@astron.com" class="">File@astron.com</a><br class="">https://mailman.astron.com/mailman/listinfo/file<br class=""><span id="cid:EB6B070F-0A3D-49E9-A107-84AB79D4C8D2"><sanitizer.log></span></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></div></blockquote></div><br class=""></div></body></html>