<html><head><meta http-equiv="content-type" content="text/html; charset=utf-8"></head><body style="overflow-wrap: break-word; -webkit-nbsp-mode: space; line-break: after-white-space;">Fixed, thanks!<div><br></div><div>christos<br><div><div><br><blockquote type="cite"><div>On May 20, 2025, at 6:49 AM, Vincent Mihalkovic <vmihalko@redhat.com> wrote:</div><br class="Apple-interchange-newline"><div><p><defanged_div dir="ltr">Hi,</defanged_div></p><p><defanged_div></defanged_div></p><p class="gmail-p1" defanged_style="color:rgb(0,0,0)">I noticed that after commit<defanged_span class="gmail-Apple-converted-space"> </defanged_span><a href="https://github.com/file/file/commit/6bc6cf03ad4ad136088260e22f30c6d191c161a3">6bc6cf03ad4ad136088260e22f30c6d191c161a3</a>, the ELF magic results have changed. Specifically, in the test data at<defanged_span class="gmail-Apple-converted-space"> </defanged_span><a href="https://github.com/file/file-tests/tree/master/db/elf">file-tests/db/elf</a>, the following difference occurs:</p><p class="gmail-p1" defanged_style="color:rgb(0,0,0)">--- reference/elf/a.ref 2025-05-13 13:52:48.260986955 +0000<br>+++ /tmp/tmp.lcLqsYkBCU/out 2025-05-13 13:53:14.249232572 +0000<br>@@ -1 +1 @@<br>-ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter /lib64/ld-linux-x86-64.so.2, for GNU/Linux 2.6.32, BuildID[sha1]=f382d7105a1c1d2b42db80c4202ea7a84c59b335, not stripped<br>+ELF 64-bit LSB executable, x86-64, version 1 (SYSV), dynamically linked, interpreter *empty*, for GNU/Linux 2.6.32, BuildID[sha1]=f382d7105a1c1d2b42db80c4202ea7a84c59b335, not stripped<br></p><div><br class="webkit-block-placeholder"></div><defanged_div><p><defanged_div><defanged_span style="">Upon reviewing the commit, I suspect a copy-paste mistake in the following lines:</defanged_span></defanged_div></p><defanged_div><p><defanged_div> else<br></defanged_div></p><defanged_div><p><defanged_div>- strlcpy(interp, "*empty*", sizeof(interp));<br>+ str = "*empty*";<br>+ strlcpy(interp, "*empty*", sizeof(interp));<br></defanged_div></p><defanged_div><p><defanged_div><br></defanged_div></p><defanged_div><p><defanged_div></defanged_div></p><p class="gmail-p1" defanged_style="color:rgb(0,0,0)">The<defanged_span class="gmail-Apple-converted-space"> </defanged_span><defanged_span class="gmail-s1">strlcpy</defanged_span><defanged_span class="gmail-Apple-converted-space"> </defanged_span>call should use the<defanged_span class="gmail-Apple-converted-space"> </defanged_span><defanged_span class="gmail-s1">str</defanged_span><defanged_span class="gmail-Apple-converted-space"> </defanged_span>variable as its source argument, not the literal string<defanged_span class="gmail-Apple-converted-space"> </defanged_span><defanged_span class="gmail-s1">"*empty*"</defanged_span>. The corrected code should be:</p><p><defanged_div> else<br></defanged_div></p><defanged_div><p><defanged_div>- strlcpy(interp, "*empty*", sizeof(interp));<br>+ str = "*empty*";<br>+ strlcpy(interp, str, sizeof(interp));</defanged_div></p><defanged_div><p><defanged_div><br></defanged_div></p><defanged_div><p class="gmail-p1" defanged_style="color:rgb(0,0,0)">best regards,</p><p class="gmail-p1" defanged_style="color:rgb(0,0,0)">Vincent Mihalkovic</p><div><br class="webkit-block-placeholder"></div><defanged_div><div><br class="webkit-block-placeholder"></div><defanged_div>
<span id="cid:f_mawdg62t0"><fix-elf-interpreter-string.patch></span>-- <br>File mailing list<br>File@astron.com<br>https://mailman.astron.com/mailman/listinfo/file<br><span id="cid:5C5A30A7-F45D-4CF7-94E8-6DC269060BFD"><sanitizer.log></span></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></defanged_div></div></blockquote></div><br></div></div></body></html>