From eran at leshem.life  Wed Apr  7 01:04:59 2021
From: eran at leshem.life (Eran Leshem)
Date: Wed, 7 Apr 2021 04:04:59 +0300
Subject: [Tcsh] change in head/tail handling in tcsh-6.22.03
Message-ID: <01e501d72b4a$095d6950$1c183bf0$@leshem.life>

Is there a plan to release 6.22.04 with a fix to this regression?

 

Thanks 

Eran

 

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210407/1b29b422/attachment.htm>

From christos at zoulas.com  Thu Apr  8 21:22:42 2021
From: christos at zoulas.com (Christos Zoulas)
Date: Thu, 8 Apr 2021 17:22:42 -0400
Subject: [Tcsh] change in head/tail handling in tcsh-6.22.03
In-Reply-To: <01e501d72b4a$095d6950$1c183bf0$@leshem.life>
References: <01e501d72b4a$095d6950$1c183bf0$@leshem.life>
Message-ID: <31F7CD08-8A2B-4F34-BC8B-242F79943376@zoulas.com>

Yes, but let me make sure that nothing else is broken on head first :-)

christos

> On Apr 6, 2021, at 9:04 PM, Eran Leshem <eran at leshem.life> wrote:
> 
> Is there a plan to release 6.22.04 with a fix to this regression?
> 
> Thanks
> Eran
> 
> 
> --
> Tcsh mailing list
> Tcsh at astron.com
> https://mailman.astron.com/mailman/listinfo/tcsh
> <sanitizer.log>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210408/cb51e5c1/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210408/cb51e5c1/attachment.asc>

From walt at drummond.us  Sat Apr 17 16:03:58 2021
From: walt at drummond.us (Walt Drummond)
Date: Sat, 17 Apr 2021 09:03:58 -0700
Subject: [Tcsh] PATCH: don't walk of the end of mesg[] on signal receipt
Message-ID: <CADCN6nxGRZtzc0Ud7+j=8we+ojomKcQ2ZGfWZA8Xa_roFB9FYw@mail.gmail.com>

There is a remote possibility of a crash in tcsh when:
- a process is running in either foreground or background, and
- the kernel delivers a signal to the process where the default action
is to coredump AND the signal number sent is greater than NSIG (ie,
the kernel has more signals than user space, or an old tcsh is running
on a newer kernel).

In this case, tcsh will walk off the end of mesg[].

The small patch below (and attached in case Gmail mucks with the
formatting) avoids this possibility by checking the signal number sent
against NSIG before indexing mesg[].

--Walt

---------------------------------

diff -ru tcsh-6.22.03/sh.proc.c tcsh-6.22.03-sigfix/sh.proc.c
--- tcsh-6.22.03/sh.proc.c 2020-11-18 09:34:01.000000000 -0800
+++ tcsh-6.22.03-sigfix/sh.proc.c 2021-04-17 07:14:33.485857299 -0700
@@ -1100,7 +1100,9 @@
  int free_ptr;

  free_ptr = 0;
- ptr = (char *)(intptr_t)mesg[pp->p_reason & 0177].pname;
+ ptr = NULL;
+ if (pp->p_reason & 0177 <= NSIG)
+ ptr = (char *)(intptr_t)mesg[pp->p_reason & 0177].pname;
  if (ptr == NULL) {
      ptr = xasprintf("%s %d", CGETS(17, 5, "Signal"),
      pp->p_reason & 0177);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: tcsh.patch
Type: text/x-patch
Size: 544 bytes
Desc: not available
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210417/9bd3e89b/attachment.bin>

From christos at zoulas.com  Mon Apr 26 17:00:27 2021
From: christos at zoulas.com (Christos Zoulas)
Date: Mon, 26 Apr 2021 13:00:27 -0400
Subject: [Tcsh] tcsh-6.22.04 is now available
Message-ID: <20210426170028.3F26917FE13@rebar.astron.com>


Hi,

tcsh-6.22.04 is now available on:
	ftp://ftp.astron.com/pub/tcsh/tcsh-6.22.04.tar.gz

This is a bug fix release fixing a regression in the head and tail
variable modifiers.

 12. V6.22.04 - 20210426
 14. Don't crash with 'bindkey "^0" clear-screen' (Karl Jeacle)
 13. Fix $x:q:h and $x:q:t return the whole string for strings not containing /

Enjoy,

christos

From msz at astrouw.edu.pl  Tue Apr 27 06:28:59 2021
From: msz at astrouw.edu.pl (Michal Szymanski)
Date: Tue, 27 Apr 2021 08:28:59 +0200
Subject: [Tcsh] tcsh-6.22.04 is now available
In-Reply-To: <20210426170028.3F26917FE13@rebar.astron.com>
References: <20210426170028.3F26917FE13@rebar.astron.com>
Message-ID: <20210427062859.GA15935@astrouw.edu.pl>

Hi,

I have somehow missed the original announcements of 6.21 and 6.22, so
I browsed the archive to find them:

https://mailman.astron.com/pipermail/tcsh/2019-May/000018.html
https://mailman.astron.com/pipermail/tcsh/2019-November/000041.html

Both state that there are no new features, just bug fixes. If so, why
the minor version gets incremented, not the "subminor" (third number)?

regards,
Michal

On Mon, Apr 26, 2021 at 01:00:27PM -0400, Christos Zoulas wrote:
> 
> Hi,
> 
> tcsh-6.22.04 is now available on:
> 	ftp://ftp.astron.com/pub/tcsh/tcsh-6.22.04.tar.gz
> 
> This is a bug fix release fixing a regression in the head and tail
> variable modifiers.
> 
>  12. V6.22.04 - 20210426
>  14. Don't crash with 'bindkey "^0" clear-screen' (Karl Jeacle)
>  13. Fix $x:q:h and $x:q:t return the whole string for strings not containing /
> 
> Enjoy,
> 
> christos
> -- 
> Tcsh mailing list
> Tcsh at astron.com
> https://mailman.astron.com/mailman/listinfo/tcsh

-- 
  Michal Szymanski (msz at astrouw dot edu dot pl)
  Warsaw University Observatory, Warszawa, POLAND

From christos at zoulas.com  Tue Apr 27 13:11:58 2021
From: christos at zoulas.com (Christos Zoulas)
Date: Tue, 27 Apr 2021 09:11:58 -0400
Subject: [Tcsh] tcsh-6.22.04 is now available
In-Reply-To: <20210427062859.GA15935@astrouw.edu.pl>
References: <20210426170028.3F26917FE13@rebar.astron.com>
 <20210427062859.GA15935@astrouw.edu.pl>
Message-ID: <9D99A4AF-D36C-40CF-A732-8A808C905CF4@zoulas.com>

This release was just to fix something that broke in 6.22.03.

Best,

christos

> On Apr 27, 2021, at 2:28 AM, Michal Szymanski <msz at astrouw.edu.pl> wrote:
> 
> Hi,
> 
> I have somehow missed the original announcements of 6.21 and 6.22, so
> I browsed the archive to find them:
> 
> https://mailman.astron.com/pipermail/tcsh/2019-May/000018.html
> https://mailman.astron.com/pipermail/tcsh/2019-November/000041.html
> 
> Both state that there are no new features, just bug fixes. If so, why
> the minor version gets incremented, not the "subminor" (third number)?
> 
> regards,
> Michal
> 
> On Mon, Apr 26, 2021 at 01:00:27PM -0400, Christos Zoulas wrote:
>> 
>> Hi,
>> 
>> tcsh-6.22.04 is now available on:
>> 	ftp://ftp.astron.com/pub/tcsh/tcsh-6.22.04.tar.gz
>> 
>> This is a bug fix release fixing a regression in the head and tail
>> variable modifiers.
>> 
>> 12. V6.22.04 - 20210426
>> 14. Don't crash with 'bindkey "^0" clear-screen' (Karl Jeacle)
>> 13. Fix $x:q:h and $x:q:t return the whole string for strings not containing /
>> 
>> Enjoy,
>> 
>> christos
>> --
>> Tcsh mailing list
>> Tcsh at astron.com
>> https://mailman.astron.com/mailman/listinfo/tcsh
> 
> --
>  Michal Szymanski (msz at astrouw dot edu dot pl)
>  Warsaw University Observatory, Warszawa, POLAND
> --
> Tcsh mailing list
> Tcsh at astron.com
> https://mailman.astron.com/mailman/listinfo/tcsh

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210427/cd58d976/attachment.asc>

From msz at astrouw.edu.pl  Tue Apr 27 13:26:52 2021
From: msz at astrouw.edu.pl (Michal Szymanski)
Date: Tue, 27 Apr 2021 15:26:52 +0200
Subject: [Tcsh] tcsh-6.22.04 is now available
In-Reply-To: <9D99A4AF-D36C-40CF-A732-8A808C905CF4@zoulas.com>
References: <20210426170028.3F26917FE13@rebar.astron.com>
 <20210427062859.GA15935@astrouw.edu.pl>
 <9D99A4AF-D36C-40CF-A732-8A808C905CF4@zoulas.com>
Message-ID: <20210427132651.GB768@astrouw.edu.pl>

Well, I understand what 6.22.04 was meant to be. I am just curious why
the two recent minor releases, 6.21 and 6.22 were announced to be just
bug fixing releases, i.e. why were they not numbered 6.20.XX.

regards, Michal

On Tue, Apr 27, 2021 at 09:11:58AM -0400, Christos Zoulas wrote:
> This release was just to fix something that broke in 6.22.03.
> 
> Best,
> 
> christos
> 
> > On Apr 27, 2021, at 2:28 AM, Michal Szymanski <msz at astrouw.edu.pl> wrote:
> > 
> > Hi,
> > 
> > I have somehow missed the original announcements of 6.21 and 6.22, so
> > I browsed the archive to find them:
> > 
> > https://mailman.astron.com/pipermail/tcsh/2019-May/000018.html
> > https://mailman.astron.com/pipermail/tcsh/2019-November/000041.html
> > 
> > Both state that there are no new features, just bug fixes. If so, why
> > the minor version gets incremented, not the "subminor" (third number)?
> > 
> > regards,
> > Michal
> > 
> > On Mon, Apr 26, 2021 at 01:00:27PM -0400, Christos Zoulas wrote:
> >> 
> >> Hi,
> >> 
> >> tcsh-6.22.04 is now available on:
> >> 	ftp://ftp.astron.com/pub/tcsh/tcsh-6.22.04.tar.gz
> >> 
> >> This is a bug fix release fixing a regression in the head and tail
> >> variable modifiers.
> >> 
> >> 12. V6.22.04 - 20210426
> >> 14. Don't crash with 'bindkey "^0" clear-screen' (Karl Jeacle)
> >> 13. Fix $x:q:h and $x:q:t return the whole string for strings not containing /
> >> 
> >> Enjoy,
> >> 
> >> christos
> >> --
> >> Tcsh mailing list
> >> Tcsh at astron.com
> >> https://mailman.astron.com/mailman/listinfo/tcsh
> > 
> > --
> >  Michal Szymanski (msz at astrouw dot edu dot pl)
> >  Warsaw University Observatory, Warszawa, POLAND
> > --
> > Tcsh mailing list
> > Tcsh at astron.com
> > https://mailman.astron.com/mailman/listinfo/tcsh
> 



-- 
  Michal Szymanski (msz at astrouw dot edu dot pl)
  Warsaw University Observatory, Warszawa, POLAND

From christos at zoulas.com  Tue Apr 27 13:33:28 2021
From: christos at zoulas.com (Christos Zoulas)
Date: Tue, 27 Apr 2021 09:33:28 -0400
Subject: [Tcsh] tcsh-6.22.04 is now available
In-Reply-To: <20210427132651.GB768@astrouw.edu.pl>
References: <20210426170028.3F26917FE13@rebar.astron.com>
 <20210427062859.GA15935@astrouw.edu.pl>
 <9D99A4AF-D36C-40CF-A732-8A808C905CF4@zoulas.com>
 <20210427132651.GB768@astrouw.edu.pl>
Message-ID: <946786E4-876F-4F4A-BF80-1D25EA26BA81@zoulas.com>

Hi,

If you look at 6.22.01, this was done as a point fix to fix a bug introduced in 6.22.00.
6.22.02 was also done to fix a typo. A good question is should 6.22.03 have been 6.23.00,
and in retrospect yes since it was not just fixing a bug. I think so. 6.22.04 started as
a single bug fix too, but ended having more changes (to fix warnings in gcc-10 for example),
so maybe that would have merited a bump (since it was not done immediately after 6.22.03).
The next one is definitely going to be 6.24.00...

Best,

christos

> On Apr 27, 2021, at 9:26 AM, Michal Szymanski <msz at astrouw.edu.pl> wrote:
> 
> Well, I understand what 6.22.04 was meant to be. I am just curious why
> the two recent minor releases, 6.21 and 6.22 were announced to be just
> bug fixing releases, i.e. why were they not numbered 6.20.XX.
> 
> regards, Michal
> 
> On Tue, Apr 27, 2021 at 09:11:58AM -0400, Christos Zoulas wrote:
>> This release was just to fix something that broke in 6.22.03.
>> 
>> Best,
>> 
>> christos
>> 
>>> On Apr 27, 2021, at 2:28 AM, Michal Szymanski <msz at astrouw.edu.pl> wrote:
>>> 
>>> Hi,
>>> 
>>> I have somehow missed the original announcements of 6.21 and 6.22, so
>>> I browsed the archive to find them:
>>> 
>>> https://mailman.astron.com/pipermail/tcsh/2019-May/000018.html
>>> https://mailman.astron.com/pipermail/tcsh/2019-November/000041.html
>>> 
>>> Both state that there are no new features, just bug fixes. If so, why
>>> the minor version gets incremented, not the "subminor" (third number)?
>>> 
>>> regards,
>>> Michal
>>> 
>>> On Mon, Apr 26, 2021 at 01:00:27PM -0400, Christos Zoulas wrote:
>>>> 
>>>> Hi,
>>>> 
>>>> tcsh-6.22.04 is now available on:
>>>> 	ftp://ftp.astron.com/pub/tcsh/tcsh-6.22.04.tar.gz
>>>> 
>>>> This is a bug fix release fixing a regression in the head and tail
>>>> variable modifiers.
>>>> 
>>>> 12. V6.22.04 - 20210426
>>>> 14. Don't crash with 'bindkey "^0" clear-screen' (Karl Jeacle)
>>>> 13. Fix $x:q:h and $x:q:t return the whole string for strings not containing /
>>>> 
>>>> Enjoy,
>>>> 
>>>> christos
>>>> --
>>>> Tcsh mailing list
>>>> Tcsh at astron.com
>>>> https://mailman.astron.com/mailman/listinfo/tcsh
>>> 
>>> --
>>> Michal Szymanski (msz at astrouw dot edu dot pl)
>>> Warsaw University Observatory, Warszawa, POLAND
>>> --
>>> Tcsh mailing list
>>> Tcsh at astron.com
>>> https://mailman.astron.com/mailman/listinfo/tcsh
>> 
> 
> 
> 
> --
>  Michal Szymanski (msz at astrouw dot edu dot pl)
>  Warsaw University Observatory, Warszawa, POLAND

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210427/4a7f8029/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20210427/4a7f8029/attachment.asc>