[Tcsh] [PATCH] Handle older bash in testsuite test 230

Kimmo Suominen kim at netbsd.org
Sat Dec 3 20:44:49 UTC 2022


This ended up not working for me when compiling on NetBSD. I've
committed a different fix, which hopefully still works for you.

https://github.com/tcsh-org/tcsh/commit/64f2f716e08bae4d1fe91a36194617411c0ba2de

Kind regards,
+ Kimmo

On Sat, 3 Dec 2022 at 19:18, Kimmo Suominen <kim at netbsd.org> wrote:
>
> Thanks, Corinna. I've committed the patch.
>
> Cheers,
> + Kimmo
>
> On Sat, 3 Dec 2022 at 18:43, Corinna Vinschen <vinschen at redhat.com> wrote:
> >
> > Test 230 checks for the string "Abort (core dumped)", but older bash
> > versions missed to print the space, i. e. "Abort(core dumped)".  For
> > that reason, test 230 fails if such an older bash is installed on the
> > system, even though the tested functionality works as desired.  Fix
> > the regular expression accordingly.
> > ---
> >  tests/variables.at | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/tests/variables.at b/tests/variables.at
> > index a4123dfa0195..16e471cf4495 100644
> > --- a/tests/variables.at
> > +++ b/tests/variables.at
> > @@ -1033,7 +1033,7 @@ if ( $status > 128 ) echo OK
> >  true
> >  echo $status
> >  ]])
> > -AT_CHECK([tcsh -f status.csh 2>&1 | sed 's/Abort (core dumped)/Abort/'], ,
> > +AT_CHECK([tcsh -f status.csh 2>&1 | sed 's/Abort \?(core dumped)/Abort/'], ,
> >  [0
> >  Abort
> >  OK
> > --
> > 2.38.1
> >
> > --
> > Tcsh mailing list
> > Tcsh at astron.com
> > https://mailman.astron.com/mailman/listinfo/tcsh


More information about the Tcsh mailing list