[Tcsh] tcsh and Alpine Linux: progress, anyone?

[Luke Mewburn]

On 22-11-30 20:39, Vlad Meșco wrote:
  | On Wed, Nov 30, 2022 at 04:55:47PM +0200, Kimmo Suominen wrote:
  | > PR#60 is the one for the diff style. It said it might help w/ the
  | > issue discussed here, so I was hoping someone would test it and
  | > confirm in the PR. I don't have Alpine or an environment where diff
  | > comes from busybox.
  | > 
  | > https://github.com/tcsh-org/tcsh/pull/60
  | > 
  | > Looking forward to more PRs to merge. :)
  | > 
  | > Cheers,
  | > + Kimmo
  | 
  | Hi,
  | 
  | Found time.
  | 
  | I tested HEAD (90f69d2f0d5844f7b966fd728a8c18aaf5b90f1b) plus the diff
  | from PR!60.
  | 
  | tl;dr
  | - Alpine 3.16.0 OK
  | - Ubuntu 22.04 OK
  | - OpenBSD 7.2 OK
  | - `sbrk()' check OK
  | - use of `diff -U0' OK

Good news.


  | OpenBSD:
  | 
  | [...]
  | 
  | make check
  | 
  | 	144: Filename substitution                          ./tests/testsuite: /home/jakkal/Projects/tcsh/testsuite.dir/at-groups/144/test-source[80]: syntax error: `}' unexpected
  | 	188: $ home                                         ./tests/testsuite: /home/jakkal/Projects/tcsh/testsuite.dir/at-groups/188/test-source[56]: syntax error: `}' unexpected
  | 	202: $ cdtohome                                     ./tests/testsuite: /home/jakkal/Projects/tcsh/testsuite.dir/at-groups/202/test-source[41]: syntax error: `}' unexpected
  | 
  | 	## ------------- ##
  | 	## Test results. ##
  | 	## ------------- ##
  | 	
  | 	ERROR: 190 tests were run,
  | 	3 failed unexpectedly.
  | 	54 tests were skipped.
  | 
  | That's "normal". The OpenBSD port has a couple of patches for those 3
  | tests:
  | 
  | 	## ------------- ##
  | 	## Test results. ##
  | 	## ------------- ##
  | 	
  | 	190 tests were successful.
  | 	54 tests were skipped.

Do you have a link to those patches so that I can review for integration
into the mainline testsuite?


  | Much better. And yes, it still uses the system malloc.
  | 
  | I can confirm Luke's commits are solid, nothing breaks, and Alpine now
  | builds without patches. And I assume also other musl libc distros like
  | Void(-musl) can drop their patches as well.

Thanks for confirming. Appreciate it!



regards,
Luke.