[Tcsh] tcsh-6.24.14 is now available

[Christos Zoulas]

Is this caused by a typo?

diff --git a/sh.file.c b/sh.file.c
index c6742c4c..35a29726 100644
--- a/sh.file.c
+++ b/sh.file.c
@@ -590,7 +590,7 @@ again:                              /* search for matches */
 static int
 compare(const void *p, const void *q)
 {
-#if defined (WIDE_STRINGS) && !defined (UTF16_STRING)
+#if defined (WIDE_STRINGS) && !defined (UTF16_STRINGS)
     errno = 0;
 
     return (wcscoll(*(Char *const *) p, *(Char *const *) q));


> On Nov 28, 2024, at 4:55 AM, Dr. Werner Fink <werner at suse.de> wrote:
> 
> Signed PGP part
> On 2024/11/26 21:15:52 +0200, Kimmo Suominen wrote:
>> Hello,
>> 
>> I'm pleased to announce that tcsh-6.24.14 is available.  This release
>> fixes issues with S-JIS handling.  It also adds redirection handling in
>> bracketed expressions, and history searches in history expansion.
>> 
>> Tcsh is an enhanced version of the Berkeley C-shell that offers command
>> line editing and completion plus many other little things that preserve
>> the length of your fingers.
>> 
>> Tcsh runs on most UNIX machines, as well as Windows.
>> 
>> You can get tcsh from http://ftp.astron.com/pub/tcsh/tcsh-6.24.14.tar.gz
>> 
>> SHA2-256(tcsh-6.24.14.tar.gz)= 36880f258a63fc11fe72a65098b585ebc4ecdee24388b8ebec97e6ae8e485318
>> 
>> The latest source is also on GitHub: https://github.com/tcsh-org/tcsh
>> 
>> Binaries for Debian and Ubuntu: https://deb.tcsh.org
> 
> This breaks build on 32bit architectures:
> 
> diff -urp tcsh-6.24.13/config_f.h tcsh-6.24.14/config_f.h
> --- tcsh-6.24.13/config_f.h     2024-06-12 09:47:58.753288937 +0200
> +++ tcsh-6.24.14/config_f.h     2024-11-28 09:44:03.712332824 +0100
> @@ -64,7 +64,7 @@
>  */
> #if defined (SHORT_STRINGS) && defined (NLS) && !defined (WINNT_NATIVE) && !defined(_OSD_POSIX) && SIZEOF_WCHAR_T > 1
> # define WIDE_STRINGS
> -# if SIZEOF_WCHAR_T < 4
> +# if SIZEOF_WCHAR_T <= 4
> #  define UTF16_STRINGS
> # endif
> #endif
> 
> now we have
> 
> 
> [   18s] sh.file.c: In function ‘compare’:
> [   18s] sh.file.c:596:21: error: passing argument 1 of ‘wcscoll’ from incompatible pointer type [-Wincompatible-pointer-types]
> [   18s]   596 |     return (wcscoll(*(Char *const *) p, *(Char *const *) q));
> [   18s]       |                     ^~~~~~~~~~~~~~~~~~
> [   18s]       |                     |
> [   18s]       |                     Char * {aka unsigned int *}
> [   18s]       |                                         Char * {aka unsigned int *}
> [   18s] /usr/include/wchar.h:155:57: note: expected ‘const wchar_t *’ {aka ‘const long int *’} but argument is of type ‘Char *’ {aka ‘unsigned int *’}
> [   18s]   155 | extern int wcscoll (const wchar_t *__s1, const wchar_t *__s2) __THROW;
> 
> 
> to be honest I do/can not care about S-JIS in comparision to modern UTF-8
> 
> Werner
> 
> -- 
>  "Having a smoking section in a restaurant is like having
>          a peeing section in a swimming pool." -- Edward Burr
> -- 
> Tcsh mailing list
> Tcsh at astron.com <mailto:Tcsh at astron.com>
> https://mailman.astron.com/mailman/listinfo/tcsh

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20241128/262130f4/attachment.htm>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <https://mailman.astron.com/pipermail/tcsh/attachments/20241128/262130f4/attachment.asc>