[File] Support for DFF and DSF audio files

Michał Górny mgorny at gentoo.org
Tue Sep 6 08:14:00 UTC 2022


On Sun, 2022-08-28 at 11:58 +0300, Christos Zoulas wrote:
> Committed, thanks!

I think something may have went wrong here.  At least when using
the GitHub mirror, the .result files have a trailing newline that causes
the tests to fail:

Running test: ../tests/dsd64-dff.testfile
../tests/dsd64-dff.testfile: DSDIFF audio bitstream data, 1 bit, mono, "DSD 64" 2822400 Hz, no compression, ID3 version 2.0.0
test: ERROR: result was (len 96)
DSDIFF audio bitstream data, 1 bit, mono, "DSD 64" 2822400 Hz, no compression, ID3 version 2.0.0
expected (len 98)
DSDIFF audio bitstream data, 1 bit, mono, "DSD 64" 2822400 Hz, no compression, ID3 version 2.0.0

make[2]: *** [Makefile:737: check-local] Error 1


That said, IMHO it would be better to actually add a newline to all
.result files and update the test runner to expect that, as dealing with
non-newline terminated files is not widely supported by editors.

-- 
Best regards,
Michał Górny



More information about the File mailing list