[File] Support for DFF and DSF audio files

[Christos Zoulas]

Yes the trailing newline issue has bitten us quite a few times. Perhaps you are right, and we should just eat the newline instead of complaining.
Next time.

christos

> On Sep 6, 2022, at 4:14 AM, Michał Górny <mgorny at gentoo.org> wrote:
> 
> On Sun, 2022-08-28 at 11:58 +0300, Christos Zoulas wrote:
>> Committed, thanks!
> 
> I think something may have went wrong here.  At least when using
> the GitHub mirror, the .result files have a trailing newline that causes
> the tests to fail:
> 
> Running test: ../tests/dsd64-dff.testfile
> ../tests/dsd64-dff.testfile: DSDIFF audio bitstream data, 1 bit, mono, "DSD 64" 2822400 Hz, no compression, ID3 version 2.0.0
> test: ERROR: result was (len 96)
> DSDIFF audio bitstream data, 1 bit, mono, "DSD 64" 2822400 Hz, no compression, ID3 version 2.0.0
> expected (len 98)
> DSDIFF audio bitstream data, 1 bit, mono, "DSD 64" 2822400 Hz, no compression, ID3 version 2.0.0
> 
> make[2]: *** [Makefile:737: check-local] Error 1
> 
> 
> That said, IMHO it would be better to actually add a newline to all
> .result files and update the test runner to expect that, as dealing with
> non-newline terminated files is not widely supported by editors.
> 
> --
> Best regards,
> Michał Górny

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 235 bytes
Desc: Message signed with OpenPGP
URL: <https://mailman.astron.com/pipermail/file/attachments/20220907/c53a5fa2/attachment.asc>